docs(spanner-jdbc): update connection_properties.md documentation - #14035
docs(spanner-jdbc): update connection_properties.md documentation#14035olavloite wants to merge 10 commits into
Conversation
Regenerate the connection_properties.md file for the Spanner JDBC driver to include the latest connection properties.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the connection properties documentation to include several new configuration options, such as dynamic channel pool watermarks, gRPC keep-alive settings, and credentials. The reviewer suggests ensuring consistency by using the lowercase form "enabledynamicchannelpool" instead of camelCase when referencing this property in the descriptions.
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
| | credentialsprovider | The class name of the com.google.api.gax.core.CredentialsProvider implementation that should be used to obtain credentials for connections. | | | STARTUP | | ||
| | databaserole | Sets the database role to use for this connection. The default is privileges assigned to IAM role | | | STARTUP | | ||
| | databoostenabled | Enable data boost for all partitioned queries that are executed by this connection. This setting is only used for partitioned queries and is ignored by all other statements. | false | true, false | USER | | ||
| | dcpconcurrentstreamslowwatermark | The concurrent streams low watermark in the dynamic channel pool. Only used when enableDynamicChannelPool is true. | | | STARTUP | |
There was a problem hiding this comment.
I don't think this option has any relevance on actual DCP scaleup implementation in grpc-gcp
There was a problem hiding this comment.
The changes in this PR are auto-generated, so we can't make any changes to the description here. The connection property + description was added here: #12951
So if the description is inaccurate, then we need to make a similar change like that in a separate PR.
There was a problem hiding this comment.
Thanks for clarifying, we need a task to cleanup and remove configs which are not relevant for the finalized DCP design which is also what Go follows.
0fa75c1 to
eec6783
Compare
3 participants
Regenerate the connection_properties.md file for the Spanner JDBC driver to include the latest connection properties.
This pull request also fixes a build error for the Spanner JDBC driver, as the tests for the shaded and single jar builds failed, and the tests with GraalVM failed.